This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Make s16 G_ICMP legal
ClosedPublic

Authored by arsenm on Jun 18 2019, 4:48 AM.

Details

Reviewers
tstellar

Diff Detail

Event Timeline

arsenm created this revision.Jun 18 2019, 4:48 AM
nhaehnle added inline comments.Jun 24 2019, 8:45 AM
test/CodeGen/AMDGPU/GlobalISel/regbankselect-icmp.mir
1 ↗(On Diff #205303)

Why stop autogenerating this? Why remove the CHECK lines?

arsenm marked an inline comment as done.Jun 24 2019, 8:46 AM
arsenm added inline comments.
test/CodeGen/AMDGPU/GlobalISel/regbankselect-icmp.mir
1 ↗(On Diff #205303)

This is a bad diff, all the checks should be generated

arsenm updated this revision to Diff 206241.Jun 24 2019, 9:27 AM

Remove tests that belong with the next patch

tstellar accepted this revision.Jul 8 2019, 9:10 PM

LGTM.

This revision is now accepted and ready to land.Jul 8 2019, 9:10 PM
arsenm closed this revision.Jul 9 2019, 7:10 AM

r365486