This is an archive of the discontinued LLVM Phabricator instance.

Stop counting pops in tsan/check_analyze.sh.
ClosedPublic

Authored by eugenis on Jun 17 2019, 11:27 AM.

Details

Summary

It looks like LLVM has started doing less tail duplication in this code,
or something like that, resulting in a significantly smaller number of
pop instructions (16 -> 12). Removing the check.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis created this revision.Jun 17 2019, 11:27 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 17 2019, 11:27 AM
Herald added subscribers: Restricted Project, kubamracek. · View Herald Transcript
vitalybuka accepted this revision.Jun 17 2019, 12:53 PM
vitalybuka added inline comments.
compiler-rt/lib/tsan/check_analyze.sh
40 ↗(On Diff #205132)

Why keep commented?

This revision is now accepted and ready to land.Jun 17 2019, 12:53 PM
eugenis updated this revision to Diff 205159.Jun 17 2019, 12:56 PM

remove commented lines

This revision was automatically updated to reflect the committed changes.