Page MenuHomePhabricator

[analyzer] Fix JSON dumps for ExplodedNodes
ClosedPublic

Authored by Charusso on Jun 17 2019, 8:43 AM.

Details

Summary
  • Now we could see the has_report property in trim-egraph mode.
  • This patch also removes the trailing comma after each node.

Diff Detail

Repository
rL LLVM

Event Timeline

Charusso created this revision.Jun 17 2019, 8:43 AM
Charusso marked an inline comment as done.Jun 17 2019, 8:44 AM
Charusso added inline comments.
clang/test/Analysis/dump_egraph.c
3 ↗(On Diff #205086)

This did nothing.

NoQ accepted this revision.Jun 17 2019, 12:42 PM
NoQ added inline comments.
clang/test/Analysis/dump_egraph.c
3 ↗(On Diff #205086)

Let's fix it by adding another // RUN: cat %t.dot | FileCheck %s after this line instead, so that both trimmed graph and untrimmed graph gets tested.

This revision is now accepted and ready to land.Jun 17 2019, 12:42 PM
Charusso updated this revision to Diff 205208.Jun 17 2019, 3:54 PM
Charusso edited the summary of this revision. (Show Details)
Charusso marked 2 inline comments as done.

Thanks for the review!

clang/test/Analysis/dump_egraph.c
3 ↗(On Diff #205086)

I am not sure why Report.getErrorNode() == N is not enough, but now it passes well and satisfies the problem when we reported something on hidden nodes.

This revision was automatically updated to reflect the committed changes.
Charusso marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2019, 9:08 AM