Page MenuHomePhabricator

[analyzer] print() JSONify: Stable LocationContext IDs
AbandonedPublic

Authored by Charusso on Jun 24 2019, 10:01 AM.

Details

Reviewers
NoQ
Summary

-

Diff Detail

Event Timeline

Charusso created this revision.Jun 24 2019, 10:01 AM
NoQ added a comment.Jun 24 2019, 7:20 PM

In normal dumps i'd rather have it the old way because it's similar to how stack frames are displayed in the debugger.

And in exploded graph rewriter we can always reverse our lists if we want; this number isn't really telling us much.

NoQ added a comment.Jun 24 2019, 7:21 PM

I think i'd rather remove it entirely.

Charusso abandoned this revision.Jun 24 2019, 7:27 PM
In D63727#1556821, @NoQ wrote:

I think i'd rather remove it entirely.

I have seen a TODO in the differentiation of such indices, just why I made it. Okai.