This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add ds_gws_init / ds_gws_barrier intrinsics
ClosedPublic

Authored by arsenm on Jun 14 2019, 3:23 PM.

Details

Reviewers
rampitec
b-sumner
Summary

There may or may not be additional work to handle this correctly on
SI/CI.

Diff Detail

Event Timeline

arsenm created this revision.Jun 14 2019, 3:23 PM
arsenm updated this revision to Diff 204867.Jun 14 2019, 3:41 PM

Set mayLoad = 0 on DS_GWS_INIT, add test where I'm not sure if a wait should be implicitly inserted. The waitcnt tracking uses register uses, not memory dependencies, so I think a fence should be required

arsenm updated this revision to Diff 204868.Jun 14 2019, 3:44 PM

Failed to attach one of the tests

arsenm updated this revision to Diff 204872.Jun 14 2019, 3:58 PM

Force skips, since I assume these try to run but don't work correctly with exec = 0

rampitec added inline comments.Jun 14 2019, 5:38 PM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
2074

This need a better explanation. Can we get a clarification before submitting this?

This revision is now accepted and ready to land.Jun 16 2019, 9:18 AM
arsenm closed this revision.Jun 18 2019, 6:17 AM

r363678