Page MenuHomePhabricator

[analyzer] Fix JSON dumps for store clusters.
ClosedPublic

Authored by NoQ on Jun 14 2019, 2:59 PM.

Details

Summary

Include a unique pointer so that it was possible to figure out if it's the same cluster in different program states.

Diff Detail

Event Timeline

NoQ created this revision.Jun 14 2019, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2019, 2:59 PM
Charusso accepted this revision.Jun 14 2019, 3:03 PM

Thanks you!

clang/lib/StaticAnalyzer/Core/RegionStore.cpp
215

People say extra parens are bad. So as they are the root of the evil, could you remove it, please?
(I also like to emphasize same stuff packed into parens for better understanding/readability, but we are the minority.)

This revision is now accepted and ready to land.Jun 14 2019, 3:03 PM
NoQ updated this revision to Diff 204874.Jun 14 2019, 4:05 PM

Fair enough, they aren't really needed here.

NoQ marked an inline comment as done.Jun 14 2019, 4:05 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2019, 4:31 PM