This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Make ClangTidyCheck::OptionsView public.
ClosedPublic

Authored by ymandel on Jun 13 2019, 10:33 AM.

Details

Summary

The OptionsView class is currently protected. This constraint prevents tidies from passing the OptionsView to, for example, a helper function. Similarly, TransformerClangTidyCheck cannot pass the OptionsView object to functions that generate tooling::RewriteRules. The latter is needed to allow the definition of such rules to depend on the clang-tidy options, as demonstrated in the child revision.

Event Timeline

ymandel created this revision.Jun 13 2019, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 10:33 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
gribozavr accepted this revision.Jun 13 2019, 10:34 AM
This revision is now accepted and ready to land.Jun 13 2019, 10:34 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 12:01 PM