Page MenuHomePhabricator

PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used
ClosedPublic

Authored by erichkeane on Jun 13 2019, 10:07 AM.

Details

Summary

This matches the GCC behavior, __cxa_thread_atexit should be permissible
even though cxa_atexit is disabled.

Diff Detail

Event Timeline

erichkeane created this revision.Jun 13 2019, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 10:07 AM
Herald added a subscriber: dexonsmith. · View Herald Transcript
rjmccall added inline comments.Jun 13 2019, 11:02 AM
clang/lib/CodeGen/ItaniumCXXABI.cpp
2373

It's fine to match the GCC behavior, and it's even somewhat explicable. Could you update the comment to explain, first of all, that this path handles both __cxa_atexit and __cxa_thread_atexit, and secondly that the option is only meant to control the former?

erichkeane marked an inline comment as done.

Update the comment as requested by @rjmccall

rjmccall accepted this revision.Jun 13 2019, 11:15 AM

Thanks!

This revision is now accepted and ready to land.Jun 13 2019, 11:15 AM