This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix input chain when gluing copies to m0
ClosedPublic

Authored by arsenm on Jun 13 2019, 7:39 AM.

Download Raw Diff

Details

Reviewers

rampitec
nhaehnle

Summary

I don't think this was causing any observable issues, but was making
reading the DAG dump confusing.

Diff Detail

Event Timeline

arsenm created this revision.Jun 13 2019, 7:39 AM

Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptJun 13 2019, 7:39 AM

LGTM

This revision is now accepted and ready to land.Jun 13 2019, 9:20 AM

r363389

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

AMDGPUISelDAGToDAG.cpp

7 lines

Diff 204536

lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

	Show First 20 Lines • Show All 495 Lines • ▼ Show 20 Lines
	}			}

	SDNode AMDGPUDAGToDAGISel::glueCopyToM0(SDNode N, SDValue Val) const {			SDNode AMDGPUDAGToDAGISel::glueCopyToM0(SDNode N, SDValue Val) const {
	const SITargetLowering& Lowering =			const SITargetLowering& Lowering =
	static_cast<const SITargetLowering>(getTargetLowering());			static_cast<const SITargetLowering>(getTargetLowering());

	// Write max value to m0 before each load operation			// Write max value to m0 before each load operation

	SDValue M0 = Lowering.copyToM0(*CurDAG, CurDAG->getEntryNode(), SDLoc(N),			assert(N->getOperand(0).getValueType() == MVT::Other && "Expected chain");

				SDValue M0 = Lowering.copyToM0(*CurDAG, N->getOperand(0), SDLoc(N),
	Val);			Val);

	SDValue Glue = M0.getValue(1);			SDValue Glue = M0.getValue(1);

	SmallVector <SDValue, 8> Ops;			SmallVector <SDValue, 8> Ops;
	for (unsigned i = 0, e = N->getNumOperands(); i != e; ++i)			Ops.push_back(M0); // Replace the chain.
				for (unsigned i = 1, e = N->getNumOperands(); i != e; ++i)
	Ops.push_back(N->getOperand(i));			Ops.push_back(N->getOperand(i));

	Ops.push_back(Glue);			Ops.push_back(Glue);
	return CurDAG->MorphNodeTo(N, N->getOpcode(), N->getVTList(), Ops);			return CurDAG->MorphNodeTo(N, N->getOpcode(), N->getVTList(), Ops);
	}			}

	SDNode AMDGPUDAGToDAGISel::glueCopyToM0LDSInit(SDNode N) const {			SDNode AMDGPUDAGToDAGISel::glueCopyToM0LDSInit(SDNode N) const {
	if (cast<MemSDNode>(N)->getAddressSpace() != AMDGPUAS::LOCAL_ADDRESS \|\|			if (cast<MemSDNode>(N)->getAddressSpace() != AMDGPUAS::LOCAL_ADDRESS \|\|
	▲ Show 20 Lines • Show All 1,990 Lines • Show Last 20 Lines