This is an archive of the discontinued LLVM Phabricator instance.

[llvm-nm] Fix docs and help text for --print-size
ClosedPublic

Authored by jhenderson on Jun 11 2019, 8:26 AM.

Details

Summary

The --print-size help text and documentation claimed that the size was printed instead of the address, but this is incorrect. It is printed as well as the address. This patch fixes this issue.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Jun 11 2019, 8:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2019, 8:26 AM
mtrent accepted this revision.Jun 11 2019, 10:33 AM
This revision is now accepted and ready to land.Jun 11 2019, 10:33 AM
ruiu accepted this revision.Jun 11 2019, 8:51 PM

LGTM

MaskRay accepted this revision.Jun 12 2019, 1:48 AM
MaskRay added inline comments.
docs/CommandGuide/llvm-nm.rst
124 ↗(On Diff #204078)

MachO files do not record the size. (There is currently a warning) You may add a note about this if useful.

jhenderson marked an inline comment as done.Jun 12 2019, 2:33 AM
jhenderson added inline comments.
docs/CommandGuide/llvm-nm.rst
124 ↗(On Diff #204078)

Sure. I'll add a note to the doc indicating this is not applicable for Mach-O.

Add note about Mach-O.

MaskRay accepted this revision.Jun 12 2019, 3:31 AM
This revision was automatically updated to reflect the committed changes.