Page MenuHomePhabricator

[Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler
ClosedPublic

Authored by arphaman on Jun 10 2019, 3:26 PM.

Details

Summary

The function SetUpDiagnosticLog that was called from createDiagnostics didn't handle the case where the diagnostics engine didn't own the diagnostics consumer.
This is a potential problem for a clang tool, in particular some of the follow-up patches for clang-scan-deps will need this fix.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman created this revision.Jun 10 2019, 3:26 PM
arphaman added a subscriber: cfe-commits.EditedJun 10 2019, 3:31 PM

+ cfe-commits

This revision is now accepted and ready to land.Jun 10 2019, 3:33 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2019, 4:29 PM