Page MenuHomePhabricator

[llvm-nm] Additional lit tests for command line options
ClosedPublic

Authored by chrisjackson on Jun 6 2019, 7:24 AM.

Details

Summary

Some additional and some replacement tests for nm command line options. This includes a test for --debug-syms initially discussed at D62148. Where felt appropriate some tests have been renamed.

Diff Detail

Event Timeline

chrisjackson created this revision.Jun 6 2019, 7:24 AM
mtrent accepted this revision.Jun 6 2019, 8:14 AM
This revision is now accepted and ready to land.Jun 6 2019, 8:14 AM
rupprecht accepted this revision.Jun 6 2019, 10:26 AM
MaskRay accepted this revision.Jun 6 2019, 10:38 PM
MaskRay added inline comments.
test/tools/llvm-nm/debug-syms.test
1

Nit: yaml2obj has an -o option and it seems most tests in test/tools/yaml2obj uses -o instead of > .

chrisjackson closed this revision.Sep 3 2019, 2:46 AM

This was closed with commit 7b39513302, svn r363248.

This was closed with commit 7b39513302, svn r363248.

If your description included Differential Revision: https://reviews.llvm.org/D62955 (see other commits' descriptions), the revision would have been closed automatically when you committed.

This was closed with commit 7b39513302, svn r363248.

If your description included Differential Revision: https://reviews.llvm.org/D62955 (see other commits' descriptions), the revision would have been closed automatically when you committed.

Thanks, that's what was intended in the comment but it looks like I added some whitespace that prevented the automatic close.