[lld] Allow args::getInterger to parse args larger than 2^31-1

[sbc100]

• cleanup test

[ruiu]

LGTM

lld/Common/Args.cpp

 // function metadata.
 CodeGenOpt::Level lld::args::getCGOptLevel(int OptLevelLTO) {
   if (OptLevelLTO == 3)
     return CodeGenOpt::Aggressive;
   assert(OptLevelLTO < 3);
   return CodeGenOpt::Default;
 }
 
-int lld::args::getInteger(opt::InputArgList &Args, unsigned Key, int Default) {
+int64_t lld::args::getInteger(opt::InputArgList &Args, unsigned Key,
+                              int64_t Default) {
   auto *A = Args.getLastArg(Key);
   if (!A)
     return Default;
 
-  int V;
+  int64_t V;
   if (to_integer(A->getValue(), V, 10))
     return V;
 
   StringRef Spelling = Args.getArgString(A->getIndex());
   error(Spelling + ": number expected, but got '" + A->getValue() + "'");
   return 0;
 }
 

lld/include/lld/Common/Args.h

 }
 } // namespace llvm
 
 namespace lld {
 namespace args {
 
 llvm::CodeGenOpt::Level getCGOptLevel(int OptLevelLTO);
 
-int getInteger(llvm::opt::InputArgList &Args, unsigned Key, int Default);
+int64_t getInteger(llvm::opt::InputArgList &Args, unsigned Key,
+                   int64_t Default);
 
 std::vector<StringRef> getStrings(llvm::opt::InputArgList &Args, int Id);
 
 uint64_t getZOptionValue(llvm::opt::InputArgList &Args, int Id, StringRef Key,
                          uint64_t Default);
 
 std::vector<StringRef> getLines(MemoryBufferRef MB);
 
 StringRef getFilenameWithoutExe(StringRef Path);
 
 } // namespace args
 } // namespace lld
 
 #endif

lld/test/wasm/large-memory.test

+RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.o
+
+; Verify we can parse large integers such as when we ask for 2G of total
+; memory.
+RUN: wasm-ld %t.o -o %t.wasm --max-memory=2147483648