This is an archive of the discontinued LLVM Phabricator instance.

Differential D62891

CMake: Use symlinks also on MSYS
AbandonedPublic

Authored by orgads on Jun 4 2019, 11:03 PM.

Details

Reviewers
smeenai
beanz
compnerd
zturner

Diff Detail

Repository
rL LLVM

Event Timeline

orgads created this revision.Jun 4 2019, 11:03 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptJun 4 2019, 11:03 PM
orgads updated this revision to Diff 203085.Jun 4 2019, 11:16 PM
orgads abandoned this revision.Jun 4 2019, 11:44 PM

I now see that if the user doesn't have permissions to create symlinks, cmake fails with a strange error message.

So I abandon it.

Revision Contents

PathSize
cmake/
modules/
4 lines
2 lines

Diff 203085

cmake/modules/AddLLVM.cmake

Context not available.
if(NOT ARG_OUTPUT_DIR) if(NOT ARG_OUTPUT_DIR)
# If you're not overriding the OUTPUT_DIR, we can make the link relative in # If you're not overriding the OUTPUT_DIR, we can make the link relative in
# the same directory. # the same directory.
if(CMAKE_HOST_UNIX) if(CMAKE_HOST_UNIX OR MSYS)
set(dest_binary "$<TARGET_FILE_NAME:${target}>") set(dest_binary "$<TARGET_FILE_NAME:${target}>")
endif() endif()
if(CMAKE_CONFIGURATION_TYPES) if(CMAKE_CONFIGURATION_TYPES)
Context not available.
endif() endif()
endif() endif()
if(CMAKE_HOST_UNIX) if(CMAKE_HOST_UNIX OR MSYS)
set(LLVM_LINK_OR_COPY create_symlink) set(LLVM_LINK_OR_COPY create_symlink)
else() else()
set(LLVM_LINK_OR_COPY copy) set(LLVM_LINK_OR_COPY copy)
Context not available.

cmake/modules/LLVMInstallSymlink.cmake

Context not available.
# See PR8397. # See PR8397.
function(install_symlink name target outdir) function(install_symlink name target outdir)
if(CMAKE_HOST_UNIX) if(CMAKE_HOST_UNIX OR MSYS)
set(LINK_OR_COPY create_symlink) set(LINK_OR_COPY create_symlink)
set(DESTDIR $ENV{DESTDIR}) set(DESTDIR $ENV{DESTDIR})
else() else()
Context not available.