Page MenuHomePhabricator

[CMake] Use libtool for runtimes when building for Apple platform
ClosedPublic

Authored by phosek on May 31 2019, 11:32 PM.

Details

Summary

LLVM CMake build already uses libtool instead of ar when building
for Apple platform and we should be using the same when building
runtimes. To do so, this change extracts the logic for finding
libtool into a separate file and then uses it from both the LLVM
build as well as the LLVM runtimes build.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.May 31 2019, 11:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2019, 11:32 PM
mcgrathr accepted this revision.May 31 2019, 11:34 PM
mcgrathr added a subscriber: mcgrathr.

lgtm

This revision is now accepted and ready to land.May 31 2019, 11:34 PM
phosek updated this revision to Diff 202577.Jun 1 2019, 7:01 PM
This revision was automatically updated to reflect the committed changes.