This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Remove excessive `dynamic.test`
ClosedPublic

Authored by grimar on May 31 2019, 3:48 AM.

Details

Summary

dynamic.test is a test that checks dumping of
dynamic tags. It uses precompiled objects as inputs
and it is completely excessive nowadays:

Now we have elf-dynamic-tags-machine-specific.test
and elf-dynamic-tags.test.
(https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test)
(https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-readobj/elf-dynamic-tags.test)

First is used to check target
specific tags and second tests the common flags.
These tests use YAML, which is much better than using precompiled binaries.

Note that new reviews tend to update the YAML based
tests to add new tags, e.g. see D62596.

So I think we should remove dynamic.test.

With this patch became possible to remove
dynamic-table-so.aarch64 binary from the inputs folder.
(other binaries are still used in other tests).

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.May 31 2019, 3:48 AM
grimar edited the summary of this revision. (Show Details)May 31 2019, 3:48 AM
MaskRay accepted this revision.May 31 2019, 3:54 AM
This revision is now accepted and ready to land.May 31 2019, 3:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2019, 6:16 AM