Page MenuHomePhabricator

[ELF] Replace a dead test in getSymVA() with assert()
ClosedPublic

Authored by MaskRay on May 31 2019, 2:36 AM.

Details

Summary

Symbols relative to discarded comdat sections are Undefined instead of
Defined now (after D59649 and D61583). The == &InputSection::Discarded
test is now dead. I cannot find a test related to this behavior.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.May 31 2019, 2:36 AM
ruiu accepted this revision.May 31 2019, 2:40 AM

LGTM

Nice!

This revision is now accepted and ready to land.May 31 2019, 2:40 AM
This revision was automatically updated to reflect the committed changes.