This is an archive of the discontinued LLVM Phabricator instance.

Differential D62723

[compiler-rt][builtins] Fix typo in definition of __aeabi_fcmpun
ClosedPublic

Authored by kschwarz on May 31 2019, 2:15 AM.

Details

Reviewers
compnerd
weimingz
Summary

If COMPILER_RT_ARMHF_TARGET is set , the definition of the AEABI runtime function aeabi_fcmpun is misspelled: aeabi_fcmpum instead of __aeabi_fcmpun.

Diff Detail

Event Timeline

kschwarz created this revision.May 31 2019, 2:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 31 2019, 2:15 AM
Herald added subscribers: llvm-commits, Restricted Project, kristof.beyls and 2 others. · View Herald Transcript
compnerd accepted this revision.May 31 2019, 2:53 PM

Oops! Nice catch. This matches the specification.

This revision is now accepted and ready to land.May 31 2019, 2:53 PM
kschwarz added a comment.Jun 3 2019, 2:47 AM

I haven’t requested commit access yet. Could you commit this for me? Thanks!

compnerd closed this revision.Jun 3 2019, 10:05 AM

SVN r362424

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
arm/
4 lines

Diff 202394

compiler-rt/lib/builtins/arm/comparesf2.S

Show First 20 Lines • Show All 242 Lines • ▼ Show 20 Lines#else
ite ls ite ls
cmpls r3, #0xff000000 cmpls r3, #0xff000000
movhi r0, #1 movhi r0, #1
#endif #endif
JMP(lr) JMP(lr)
END_COMPILERRT_FUNCTION(__unordsf2) END_COMPILERRT_FUNCTION(__unordsf2)
#if defined(COMPILER_RT_ARMHF_TARGET) #if defined(COMPILER_RT_ARMHF_TARGET)
DEFINE_COMPILERRT_FUNCTION(__aeabi_fcmpum) DEFINE_COMPILERRT_FUNCTION(__aeabi_fcmpun)
vmov s0, r0 vmov s0, r0
vmov s1, r1 vmov s1, r1
b SYMBOL_NAME(__unordsf2) b SYMBOL_NAME(__unordsf2)
END_COMPILERRT_FUNCTION(__aeabi_fcmpum) END_COMPILERRT_FUNCTION(__aeabi_fcmpun)
#else #else
DEFINE_AEABI_FUNCTION_ALIAS(__aeabi_fcmpun, __unordsf2) DEFINE_AEABI_FUNCTION_ALIAS(__aeabi_fcmpun, __unordsf2)
#endif #endif
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE