Page MenuHomePhabricator

[MIR-Canon] Skip the first N vreg names lazily.
ClosedPublic

Authored by plotfi on May 30 2019, 10:27 PM.

Details

Summary

This consolidates the vreg skip code into one function (SkipVRegs()). SkipVRegs() now knows if it should skip as if it is the first initialization or subsequent skips.

Diff Detail

Repository
rL LLVM

Event Timeline

plotfi created this revision.May 30 2019, 10:27 PM
compnerd accepted this revision.May 30 2019, 10:37 PM
compnerd added inline comments.
llvm/lib/CodeGen/MIRCanonicalizerPass.cpp
483 ↗(On Diff #202368)

Why not just initialize in the initializer list?

This revision is now accepted and ready to land.May 30 2019, 10:37 PM
plotfi marked an inline comment as done.May 30 2019, 10:38 PM
plotfi added inline comments.
llvm/lib/CodeGen/MIRCanonicalizerPass.cpp
483 ↗(On Diff #202368)

I can do that too.

plotfi updated this revision to Diff 202373.May 30 2019, 10:46 PM

using initializer list.

plotfi marked an inline comment as done.May 30 2019, 10:47 PM
This revision was automatically updated to reflect the committed changes.