Page MenuHomePhabricator

[IR] Add UnaryOperator::CreateFNegFMF(...)
ClosedPublic

Authored by cameron.mcinally on May 30 2019, 2:19 PM.

Details

Summary

I'm not sure if InstructionsTest.cpp is the correct place for this test, but it seems like the best fit.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2019, 2:19 PM
spatel accepted this revision.Jun 7 2019, 9:42 AM

LGTM

This revision is now accepted and ready to land.Jun 7 2019, 9:42 AM
spatel added inline comments.Jun 7 2019, 9:52 AM
llvm/include/llvm/IR/InstrTypes.h
168 ↗(On Diff #202297)

Sorry, I missed this on 1st glance: we should be passing the "Name" parameter through here.

cameron.mcinally marked an inline comment as done.Jun 7 2019, 10:52 AM
cameron.mcinally added inline comments.
llvm/include/llvm/IR/InstrTypes.h
168 ↗(On Diff #202297)

Good catch. I copied that from BinaryOperator::CreateFNegFMF(...). I'll update both if there are no objections.

spatel added inline comments.Jun 7 2019, 11:36 AM
llvm/include/llvm/IR/InstrTypes.h
168 ↗(On Diff #202297)

Yes, please fix both.

Closed by commit rL362828: [IR] Add UnaryOperator::CreateFNegFMF(...) (authored by mcinally, committed by ). · Explain WhyJun 7 2019, 11:57 AM
This revision was automatically updated to reflect the committed changes.