This is an archive of the discontinued LLVM Phabricator instance.

Differential D62696

AMDGPU: Use AMDGPU toolchain for other OSes
ClosedPublic

Authored by arsenm on May 30 2019, 12:50 PM.

Details

Reviewers
yaxunl
Summary

This would need more work to actually support them, but this is less
wrong than the default.

Diff Detail

Event Timeline

arsenm created this revision.May 30 2019, 12:50 PM
Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptMay 30 2019, 12:50 PM
arsenm added a comment.Jun 6 2019, 3:47 PM

ping

yaxunl accepted this revision.Jun 7 2019, 7:31 AM

LGTM

This revision is now accepted and ready to land.Jun 7 2019, 7:31 AM
arsenm closed this revision.Jun 14 2019, 6:37 AM

r363390

Revision Contents

PathSize
lib/
Driver/
2 lines
test/
Driver/
7 lines

Diff 202278

lib/Driver/Driver.cpp

Show First 20 Lines • Show All 4,611 Lines • ▼ Show 20 Lines case llvm::Triple::NaCl:
break; break;
case llvm::Triple::Fuchsia: case llvm::Triple::Fuchsia:
TC = llvm::make_unique<toolchains::Fuchsia>(*this, Target, Args); TC = llvm::make_unique<toolchains::Fuchsia>(*this, Target, Args);
break; break;
case llvm::Triple::Solaris: case llvm::Triple::Solaris:
TC = llvm::make_unique<toolchains::Solaris>(*this, Target, Args); TC = llvm::make_unique<toolchains::Solaris>(*this, Target, Args);
break; break;
case llvm::Triple::AMDHSA: case llvm::Triple::AMDHSA:
case llvm::Triple::AMDPAL:
case llvm::Triple::Mesa3D:
TC = llvm::make_unique<toolchains::AMDGPUToolChain>(*this, Target, Args); TC = llvm::make_unique<toolchains::AMDGPUToolChain>(*this, Target, Args);
break; break;
case llvm::Triple::Win32: case llvm::Triple::Win32:
switch (Target.getEnvironment()) { switch (Target.getEnvironment()) {
default: default:
if (Target.isOSBinFormatELF()) if (Target.isOSBinFormatELF())
TC = llvm::make_unique<toolchains::Generic_ELF>(*this, Target, Args); TC = llvm::make_unique<toolchains::Generic_ELF>(*this, Target, Args);
else if (Target.isOSBinFormatMachO()) else if (Target.isOSBinFormatMachO())
▲ Show 20 Lines • Show All 190 Lines • Show Last 20 Lines

test/Driver/amdgpu-toolchain.c

// RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s // RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s
// RUN: %clang -### -g -target amdgcn--amdhsa -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s
// RUN: %clang -### -target amdgcn-amd-amdpal -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s
// RUN: %clang -### -g -target amdgcn-amd-amdpal -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s
// RUN: %clang -### -target amdgcn-mesa-mesa3d -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s
// RUN: %clang -### -g -target amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s
// AS_LINK: clang{{.*}} "-cc1as" // AS_LINK: clang{{.*}} "-cc1as"
// AS_LINK: ld.lld{{.*}} "-shared" // AS_LINK: ld.lld{{.*}} "-shared"
// RUN: %clang -### -g -target amdgcn--amdhsa -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s
// DWARF_VER: "-dwarf-version=5" // DWARF_VER: "-dwarf-version=5"