Page MenuHomePhabricator

[llvm-objcopy][MachO] Print an error message on use of unsupported options
ClosedPublic

Authored by seiya on May 29 2019, 3:35 AM.

Details

Summary

It is better to print an error message instead of silently ignoring unsupported options.

As mentioned in https://reviews.llvm.org/D57045, this is not the best solution and we should print which flag is not supported at some time.

Diff Detail

Event Timeline

seiya created this revision.May 29 2019, 3:35 AM
seiya set the repository for this revision to rG LLVM Github Monorepo.May 29 2019, 3:35 AM
seiya edited the summary of this revision. (Show Details)May 29 2019, 3:52 AM
This revision is now accepted and ready to land.May 29 2019, 3:55 AM
llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
20

where is this used btw ?

jakehehrlich accepted this revision.May 29 2019, 2:09 PM
rupprecht accepted this revision.May 29 2019, 2:26 PM
seiya marked an inline comment as done.May 29 2019, 3:03 PM
seiya added inline comments.
llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
20

Used in object_error::parse_failed.

This revision was automatically updated to reflect the committed changes.