This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Added target feature +disable-form-clauses

Authored by tpr on May 29 2019, 1:12 AM.



With LLPC, previous investigation has suggested that si-scheduler
interacts badly with SiFormMemoryClauses on an XNACK target in some

That needs further investigation in the future. In the meantime, this
commit adds a target feature to disable SIFormMemoryClauses on a
per-function basis for LLPC to use.

Diff Detail


Event Timeline

tpr created this revision.May 29 2019, 1:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2019, 1:12 AM

Can we avoid negative (e.g. "disable") features?

Actually it doesn't look like a feature at all. This is rather an option, which can also be set on a per-function basis. Also note, making it a feature will make it incompatible for inlining into parent and incompatible with any function which may be inlined into it.

tpr updated this revision to Diff 202218.May 30 2019, 8:25 AM

V2: Target-specific attribute instead of target feature, as suggested by Stas.

This revision is now accepted and ready to land.May 30 2019, 9:54 AM
This revision was automatically updated to reflect the committed changes.