This is an archive of the discontinued LLVM Phabricator instance.

String tests include "test_macros.h"
ClosedPublic

Authored by zoecarver on May 26 2019, 12:02 PM.

Details

Summary

This patch adds test_macros.h to any string tests that use TEST_STD_VER. All tests should include test_macros.h but, I didn't want to make this patch to big, so I am starting with only these files. I can make another patch for the rest of string or add it to this one if you want.

Diff Detail

Event Timeline

zoecarver created this revision.May 26 2019, 12:02 PM
ldionne accepted this revision.May 27 2019, 7:03 AM
This revision is now accepted and ready to land.May 27 2019, 7:03 AM

Sorry if you spent a lot of time looking over this. I meant to close it (and forgot). Marshall and I talked a bit about this, and he is going to "take over" and commit the other ~3200 files that need changes.

zoecarver closed this revision.May 27 2019, 9:45 AM

SGTM. It took only a minute to review!