Page MenuHomePhabricator

[LLVM-C] Improve Bindings to The Internalize Pass
ClosedPublic

Authored by CodaFi on May 25 2019, 2:19 PM.

Details

Summary

Adds a binding to the internalize pass that allows the caller to pass a function pointer that acts as the visibility-preservation predicate. Previously, one could only pass an unsigned value (not LLVMBool?) that directed the pass to consider "main" or not.

Diff Detail

Repository
rL LLVM

Event Timeline

CodaFi created this revision.May 25 2019, 2:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2019, 2:19 PM
whitequark accepted this revision.May 25 2019, 2:24 PM

LGTM. Maybe a comment about expected lifetime of Context would be useful, but it seems fairly obvious.

This revision is now accepted and ready to land.May 25 2019, 2:24 PM
harlanhaskins accepted this revision.May 25 2019, 2:30 PM
CodaFi updated this revision to Diff 201429.May 25 2019, 4:36 PM

Document the lifetime of the context parameter

kren1 added a subscriber: kren1.Jul 22 2019, 6:11 AM

Is there a plan to commit this? I would like to add the OCaml binding for it ...

This revision was automatically updated to reflect the committed changes.