Page MenuHomePhabricator

[CMake] [Runtimes] Set *_STANDALONE_BUILD
ClosedPublic

Authored by beanz on May 24 2019, 10:24 AM.

Details

Summary

The runtimes use *_STANDALONE_BUILD=OFF to signify that clang is an in-tree target. This is not the case with the runtime builds, so we really need this set to ON.

In order to resolve the issues phosek was having with checks, we should use checks that don't link. We can use compiler-rt's try_compile_only as a basis for that.

This patch is *required* to be able to run the runtime libraries check-* targets.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz created this revision.May 24 2019, 10:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 10:24 AM
Herald added a subscriber: mgorny. · View Herald Transcript

This is fine with me but I'd first like to test this against our build to make sure it doesn't break anything.

phosek accepted this revision.May 28 2019, 12:51 AM

LGTM seems to be working fine in our build.

This revision is now accepted and ready to land.May 28 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.