It looks like since INLINEASM_BR was created off of INLINEASM (r353563),
a few checks for INLINEASM needed to be updated to check for either
case.
pr/41999
Differential D62403
[PowerPC] check for INLINEASM_BR along w/ INLINEASM nickdesaulniers on May 24 2019, 9:33 AM. Authored by
Details It looks like since INLINEASM_BR was created off of INLINEASM (r353563), pr/41999
Diff Detail
Event TimelineComment Actions Also, I'm fine with these as by-inspection changes, but if there are reasonably-easy ways to write test cases (or update existing ones), please do. Comment Actions
Thank you for the review, and I understand. Short of writing a full on unit test (llvm/unittests/Target/PowerPC/testcase.cpp) I don't have a reproducer in hand nor know enough about PPC assembly to derive a test case that exposes the same issue as seen on arm. Maybe something where a large amount of inline asm in a callbr would prevent inlining, but even that is kind of brittle. Merging for now, but if you have more ideas I'm happy to commit tests after the fact. |