# [lldb] followup fix for https://reviews.llvm.org/D62305ClosedPublicActions

Authored by kwk on May 23 2019, 11:51 AM.

# Details

Summary

Fixing this error on windows build bot:

```E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'nullptr' to 'lldb::thread_result_t'
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(40): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(50): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type```

# Diff Detail

Repository
rLLDB LLDB

### Event Timeline

kwk created this revision.May 23 2019, 11:51 AM
Herald added a project: Restricted Project. May 23 2019, 11:51 AM
kwk added reviewers: .May 23 2019, 11:51 AM

This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere.

I already pushed a fix for this. There were additional errors in the gdb remote code. Since I don't have a Windows I'm waiting on the Windows bot to see what else needs to be fixed :-)

JDevlieghere accepted this revision.May 23 2019, 1:00 PM

nvm my previous comment, I didn't check the left hand side...

LGTM!

This revision is now accepted and ready to land.May 23 2019, 1:00 PM
This revision was automatically updated to reflect the committed changes.

I reverted this because it broke the Windows bot again :(

```E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'initializer list' to 'lldb::thread_result_t'
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): note: Non-class type 'lldb::thread_result_t' cannot be initialized with a parenthesized initializer list