This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode
ClosedPublic

Authored by Anastasia on May 23 2019, 11:38 AM.

Details

Summary

The direction is to allow it as an extension to the kernel language 2.0 and above.

https://github.com/KhronosGroup/OpenCL-Docs/issues/66

For the published OpenCL C spec there might be extra work still needed but I am enabling this at least in C++ mode for now.

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.May 23 2019, 11:38 AM
Anastasia updated this revision to Diff 201165.May 24 2019, 2:42 AM

Fixed atomic_max and atomic_min. Thanks to David for pointing this out on the bug!

svenvh accepted this revision.May 29 2019, 8:42 AM

LGTM, please address style issue before committing.

test/Headers/opencl-c-header.cl
79 ↗(On Diff #201165)

Probably better to follow the style of the other tests above (i.e. indent and brace placement).

This revision is now accepted and ready to land.May 29 2019, 8:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2019, 9:17 AM