This is an archive of the discontinued LLVM Phabricator instance.

It is definitely a win at least for local symbols. For local symbols, we store pointers to the beginning of symbol names, but oftentime we ended up not having to compute their sizes.

Closed by commit rL361364: Copy symbol length when we replace a symbol. (authored by ruiu). · Explain WhyMay 22 2019, 2:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lld/

ELF/

Symbols.h

5 lines

Diff 200650

lld/ELF/Symbols.h

Show First 20 Lines • Show All 476 Lines • ▼ Show 20 Lines	void Symbol::replace(const Symbol &New) {
Visibility = Old.Visibility;		Visibility = Old.Visibility;
IsUsedInRegularObj = Old.IsUsedInRegularObj;		IsUsedInRegularObj = Old.IsUsedInRegularObj;
ExportDynamic = Old.ExportDynamic;		ExportDynamic = Old.ExportDynamic;
CanInline = Old.CanInline;		CanInline = Old.CanInline;
Traced = Old.Traced;		Traced = Old.Traced;
IsPreemptible = Old.IsPreemptible;		IsPreemptible = Old.IsPreemptible;
ScriptDefined = Old.ScriptDefined;		ScriptDefined = Old.ScriptDefined;

		// Symbol length is computed lazily. If we already know a symbol length,
		// propagate it.
		if (NameData == New.NameData && NameSize == 0 && New.NameSize != 0)
		NameSize = New.NameSize;

// Print out a log message if --trace-symbol was specified.		// Print out a log message if --trace-symbol was specified.
// This is for debugging.		// This is for debugging.
if (Traced)		if (Traced)
printTraceSymbol(this);		printTraceSymbol(this);
}		}

void maybeWarnUnorderableSymbol(const Symbol *Sym);		void maybeWarnUnorderableSymbol(const Symbol *Sym);
} // namespace elf		} // namespace elf
} // namespace lld		} // namespace lld

#endif		#endif

This is an archive of the discontinued LLVM Phabricator instance.

Copy symbol length when we replace a symbol.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 200650

lld/ELF/Symbols.h

Copy symbol length when we replace a symbol.
ClosedPublic