This is an archive of the discontinued LLVM Phabricator instance.

Differential D62224

Add checks before dereferencing pointers
ClosedPublic

Authored by hbae on May 21 2019, 3:32 PM.

Details

Reviewers
tlwilmar
jlpeyton
AndreyChurbanov
Commits
rOMP362111: Add checks before pointer dereferencing
rG7c75ac0c60d6: Add checks before pointer dereferencing
rL362111: Add checks before pointer dereferencing
Summary

This change adds checks before dereferencing a pointer returned from a function.

Diff Detail

Event Timeline

hbae created this revision.May 21 2019, 3:32 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMay 21 2019, 3:32 PM
AndreyChurbanov accepted this revision.May 22 2019, 5:25 AM

LGTM

This revision is now accepted and ready to land.May 22 2019, 5:25 AM
Closed by commit rG7c75ac0c60d6: Add checks before pointer dereferencing (authored by hbae). · Explain WhyMay 30 2019, 11:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
openmp/
runtime/
src/
6 lines

Diff 202243

openmp/runtime/src/ompt-specific.cpp

Show First 20 Lines • Show All 204 Lines • ▼ Show 20 Lines
//---------------------------------------------------------- //----------------------------------------------------------
// state support // state support
//---------------------------------------------------------- //----------------------------------------------------------
void __ompt_thread_assign_wait_id(void *variable) { void __ompt_thread_assign_wait_id(void *variable) {
kmp_info_t *ti = ompt_get_thread(); kmp_info_t *ti = ompt_get_thread();
if (ti)
ti->th.ompt_thread_info.wait_id = (ompt_wait_id_t)(uintptr_t)variable; ti->th.ompt_thread_info.wait_id = (ompt_wait_id_t)(uintptr_t)variable;
} }
int __ompt_get_state_internal(ompt_wait_id_t *omp_wait_id) { int __ompt_get_state_internal(ompt_wait_id_t *omp_wait_id) {
kmp_info_t *ti = ompt_get_thread(); kmp_info_t *ti = ompt_get_thread();
if (ti) { if (ti) {
if (omp_wait_id) if (omp_wait_id)
*omp_wait_id = ti->th.ompt_thread_info.wait_id; *omp_wait_id = ti->th.ompt_thread_info.wait_id;
▲ Show 20 Lines • Show All 205 Lines • ▼ Show 20 Linesint __ompt_get_task_info_internal(int ancestor_level, int *type,
return 0; return 0;
} }
int __ompt_get_task_memory_internal(void **addr, size_t *size, int blocknum) { int __ompt_get_task_memory_internal(void **addr, size_t *size, int blocknum) {
if (blocknum != 0) if (blocknum != 0)
return 0; // support only a single block return 0; // support only a single block
kmp_info_t *thr = ompt_get_thread(); kmp_info_t *thr = ompt_get_thread();
if (!thr)
return 0;
kmp_taskdata_t *taskdata = thr->th.th_current_task; kmp_taskdata_t *taskdata = thr->th.th_current_task;
kmp_task_t *task = KMP_TASKDATA_TO_TASK(taskdata); kmp_task_t *task = KMP_TASKDATA_TO_TASK(taskdata);
if (taskdata->td_flags.tasktype != TASK_EXPLICIT) if (taskdata->td_flags.tasktype != TASK_EXPLICIT)
return 0; // support only explicit task return 0; // support only explicit task
void *ret_addr; void *ret_addr;
int64_t ret_size = taskdata->td_size_alloc - sizeof(kmp_taskdata_t); int64_t ret_size = taskdata->td_size_alloc - sizeof(kmp_taskdata_t);
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines