Page MenuHomePhabricator

[MergeICmps] Make sorting strongly stable on the rhs.
ClosedPublic

Authored by courbet on Tue, May 21, 6:45 AM.

Details

Summary

Because the sort order was not strongly stable on the RHS, whether the
chain could merge would depend on the order of the blocks in the Phi.

EXPENSIVE_CHECKS would shuffle the blocks before sorting, resulting in
non-deterministic merging.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Tue, May 21, 6:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, May 21, 6:45 AM
gchatelet accepted this revision.Tue, May 21, 7:07 AM
This revision is now accepted and ready to land.Tue, May 21, 7:07 AM

Thanks guys!

This revision was automatically updated to reflect the committed changes.