Differential D62193

[MergeICmps] Make sorting strongly stable on the rhs.
ClosedPublic
Actions

Authored by courbet on May 21 2019, 6:45 AM.

Tags

Subscribers

hiraditya, llvm-commits, RKSimon

Details

Reviewers

Commits

rGa39852237090: [MergeICmps] Make sorting strongly stable on the rhs.
rZORGa39852237090: [MergeICmps] Make sorting strongly stable on the rhs.
rL361281: [MergeICmps] Make sorting strongly stable on the rhs.
rG122c6e6f3689: [MergeICmps] Make sorting strongly stable on the rhs.

Summary

Because the sort order was not strongly stable on the RHS, whether the
chain could merge would depend on the order of the blocks in the Phi.

EXPENSIVE_CHECKS would shuffle the blocks before sorting, resulting in
non-deterministic merging.

Diff Detail

Repository: rL LLVM

Event Timeline

courbet created this revision.May 21 2019, 6:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2019, 6:45 AM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

Harbormaster completed remote builds in B32223: Diff 200490.May 21 2019, 6:45 AM

gchatelet accepted this revision.May 21 2019, 7:07 AM

This revision is now accepted and ready to land.May 21 2019, 7:07 AM

courbet mentioned this in D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..May 21 2019, 7:11 AM

Thanks guys!

Closed by commit rL361281: [MergeICmps] Make sorting strongly stable on the rhs. (authored by courbet, committed by ). · Explain WhyMay 21 2019, 10:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/Transforms/Scalar/MergeICmps.cpp (3 lines)

Diff 200544

llvm/trunk/lib/Transforms/Scalar/MergeICmps.cpp

Loading...