This is an archive of the discontinued LLVM Phabricator instance.

[CodeComplete] Complete enumerators when preferred type is an enum
ClosedPublic

Authored by ilya-biryukov on May 16 2019, 7:28 AM.

Event Timeline

ilya-biryukov created this revision.May 16 2019, 7:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 7:28 AM
kadircet accepted this revision.May 16 2019, 8:03 AM

LGTM, thanks!

clang/test/CodeCompletion/enum-preferred-type.cpp
14

Could you also add an else if case, with a similar fixme as in the code?
So that when someone fixes it, we can be sure that fix is working.

This revision is now accepted and ready to land.May 16 2019, 8:03 AM
ilya-biryukov marked an inline comment as done.
  • add a test case with a fixme
kadircet added inline comments.May 16 2019, 8:34 AM
clang/test/CodeCompletion/enum-preferred-type.cpp
20

I suppose line number needs to be 14?

ilya-biryukov marked 2 inline comments as done.
  • Fix a line number

Thanks for a quick review!

clang/test/CodeCompletion/enum-preferred-type.cpp
20

Right. Otherwise tests fail.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 9:06 AM