Details
Details
- Reviewers
kadircet - Commits
- rZORG42d315f4fec8: [CodeComplete] Complete enumerators when preferred type is an enum
rG42d315f4fec8: [CodeComplete] Complete enumerators when preferred type is an enum
rG600ec01b7e27: [CodeComplete] Complete enumerators when preferred type is an enum
rC360912: [CodeComplete] Complete enumerators when preferred type is an enum
rL360912: [CodeComplete] Complete enumerators when preferred type is an enum
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 31987 Build 31986: arc lint + arc unit
Event Timeline
Comment Actions
LGTM, thanks!
clang/test/CodeCompletion/enum-preferred-type.cpp | ||
---|---|---|
13 | Could you also add an else if case, with a similar fixme as in the code? |
clang/test/CodeCompletion/enum-preferred-type.cpp | ||
---|---|---|
20 | I suppose line number needs to be 14? |
Comment Actions
Thanks for a quick review!
clang/test/CodeCompletion/enum-preferred-type.cpp | ||
---|---|---|
20 | Right. Otherwise tests fail. |
Could you also add an else if case, with a similar fixme as in the code?
So that when someone fixes it, we can be sure that fix is working.