Page MenuHomePhabricator

[lld] Remove 2>&1 from --trace-symbol tests
ClosedPublic

Authored by sbc100 on Tue, May 14, 7:43 PM.

Details

Summary

The tracing goes to stdout so this is not needed.

Also remove the "not" from the final check in ELF/trace-symbols.s.
According the comment the check is that we don't crash, so we should
be checking for success here. Previously this step is erroring with
undefined symbols because it didn't include all the needed objects.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Tue, May 14, 7:43 PM
Herald added a project: Restricted Project. · View Herald Transcript
sbc100 added a reviewer: ruiu.Tue, May 14, 7:44 PM
sbc100 retitled this revision from [LLD] Remove 2>&1 from --trace-symbol tests to [lld] Remove 2>&1 from --trace-symbol tests.
sbc100 edited the summary of this revision. (Show Details)Tue, May 14, 8:13 PM
sbc100 updated this revision to Diff 199550.Tue, May 14, 8:13 PM
  • Fix special symbol crash
ruiu accepted this revision.Tue, May 14, 10:54 PM

LGTM

This revision is now accepted and ready to land.Tue, May 14, 10:54 PM
This revision was automatically updated to reflect the committed changes.