Page MenuHomePhabricator

[tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++
ClosedPublic

Authored by xingxue on May 14 2019, 7:59 AM.

Details

Summary

When libc++ is used to build LLVM libraries, these libraries have dependencies on libc++ and C++ STL signatures in these libraries are corresponding to libc++ implementation. Therefore, -stdlib=libc++ is required on the C++ compiler command for building GO tests that link with these LLVM libraries.

Diff Detail

Repository
rL LLVM

Event Timeline

xingxue created this revision.May 14 2019, 7:59 AM
This revision is now accepted and ready to land.May 14 2019, 10:28 AM
llvm/tools/llvm-go/llvm-go.go
98 ↗(On Diff #199442)

The added lines use spaces in place of the tabs used on the other lines.

xingxue updated this revision to Diff 199509.May 14 2019, 1:51 PM
xingxue marked an inline comment as done.
xingxue marked an inline comment as done.May 14 2019, 1:54 PM
xingxue added inline comments.
llvm/tools/llvm-go/llvm-go.go
98 ↗(On Diff #199442)

Thanks for spotting this. Changed to use tabs.

This revision was automatically updated to reflect the committed changes.