This path implements member function support in PdbAstBuilder::GetOrCreateFunctionDecl. It allows to lookup and evaluate struct fields inside struct members
Details
Details
Diff Detail
Diff Detail
- Repository
- rLLDB LLDB
Event Timeline
Comment Actions
Is this still an active review or has this been abandoned?
lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp | ||
---|---|---|
1047 | It looks like CreateFunctionDeclaration can fail (returning a null pointer). Should this bail out if function_decl remains null pointer here (rather than crashing several lines later, after creating some bad mappings)? Should we assert here to make debugging easier? Also, nit, check the indentation here. |
It looks like CreateFunctionDeclaration can fail (returning a null pointer). Should this bail out if function_decl remains null pointer here (rather than crashing several lines later, after creating some bad mappings)? Should we assert here to make debugging easier?
Also, nit, check the indentation here.