Page MenuHomePhabricator

zloyrobot (Mikhail Senkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2019, 6:54 AM (68 w, 6 d)

Recent Activity

May 20 2019

zloyrobot added a comment to D60962: [NativePDB] Extend .pdb files search folders.

Adrian is on vacation now, but given that he was just waiting until you resolve my comments (which you have), I think we don't have to wait for him.

May 20 2019, 9:04 AM · Restricted Project

May 14 2019

zloyrobot created D61886: Support member functions construction and lookup in PdbAstBuilder.
May 14 2019, 3:16 AM · Restricted Project

May 13 2019

zloyrobot added a comment to D61128: Support member function types in PdbAstBuilder.

Looks like this is failing on the windows bot http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/4635/steps/test/logs/stdio.

Looking at the test, it seems that you are asserting that you will unwind into a particular offset in ntdll.dll. That sounds like an incredibly fragile assertion, which will only be true for people running the exact same version of ntdll that you happen to have...

May 13 2019, 8:09 AM · Restricted Project
zloyrobot added a comment to D60963: Fix dereferencing null pointer.

kind reminder

May 13 2019, 2:09 AM · Restricted Project, Restricted Project
zloyrobot added a comment to D60962: [NativePDB] Extend .pdb files search folders.

Thanks Pavel!

Please address Pavel's inline comments, and I'll accept this.

May 13 2019, 2:09 AM · Restricted Project
zloyrobot added a comment to D61128: Support member function types in PdbAstBuilder.

Thanks for the improved commit message. Again, sorry about the delay.

No problem, thanks for review!

May 13 2019, 2:09 AM · Restricted Project

Apr 29 2019

zloyrobot added a comment to D61128: Support member function types in PdbAstBuilder.

Thanks for the improved commit message. Again, sorry about the delay.

Apr 29 2019, 9:49 PM · Restricted Project

Apr 26 2019

zloyrobot retitled D61128: Support member function types in PdbAstBuilder from Fix stack unwinding for struct methods to Support member function types in PdbAstBuilder.
Apr 26 2019, 8:06 AM · Restricted Project

Apr 25 2019

zloyrobot created D61128: Support member function types in PdbAstBuilder.
Apr 25 2019, 6:34 AM · Restricted Project
zloyrobot added inline comments to D60962: [NativePDB] Extend .pdb files search folders.
Apr 25 2019, 5:01 AM · Restricted Project
zloyrobot updated the diff for D60962: [NativePDB] Extend .pdb files search folders.
Apr 25 2019, 4:54 AM · Restricted Project
zloyrobot added inline comments to D60962: [NativePDB] Extend .pdb files search folders.
Apr 25 2019, 2:43 AM · Restricted Project

Apr 23 2019

zloyrobot added a comment to D60963: Fix dereferencing null pointer.

test?

Apr 23 2019, 8:36 AM · Restricted Project, Restricted Project
zloyrobot updated the diff for D60962: [NativePDB] Extend .pdb files search folders.
Apr 23 2019, 6:19 AM · Restricted Project
zloyrobot updated the diff for D60962: [NativePDB] Extend .pdb files search folders.

Add test case for searching .pdb file in the same folder as .exe file

Apr 23 2019, 5:50 AM · Restricted Project

Apr 22 2019

zloyrobot added inline comments to D60962: [NativePDB] Extend .pdb files search folders.
Apr 22 2019, 11:11 PM · Restricted Project
zloyrobot created D60963: Fix dereferencing null pointer.
Apr 22 2019, 5:28 AM · Restricted Project, Restricted Project
zloyrobot created D60962: [NativePDB] Extend .pdb files search folders.
Apr 22 2019, 4:49 AM · Restricted Project