Page MenuHomePhabricator

gn build: Fewer dependencies in llvm/lib/Target
ClosedPublic

Authored by thakis on May 13 2019, 9:43 AM.

Details

Reviewers
dlj
Summary

The tablegen groups only need public_deps for inc files included
(possibly transitively) in other targets. Move inc files that are
internan to the MCTargetDesc libraries into regular deps.

Reduces total size of the generated ninja files by 4kB and increases
build parallelism a tiny bit.

Related to the changes that merged InstPrinter into MCTargetDesc
(360484, 360486 etc).

Diff Detail

Event Timeline

thakis created this revision.May 13 2019, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2019, 9:43 AM
dlj accepted this revision.May 13 2019, 9:48 AM

Ah, this makes sense. I had missed the distinction on the :tablegen targets.

This revision is now accepted and ready to land.May 13 2019, 9:48 AM
thakis closed this revision.May 13 2019, 10:00 AM

Thanks!

Landed in r360600, but forgot to add "Differential Revision:" line to commit message :/