Page MenuHomePhabricator

gn build: add Lanai target
ClosedPublic

Authored by dlj on May 10 2019, 8:50 PM.

Details

Reviewers
thakis
Summary

gn build: add Lanai target

Diff Detail

Event Timeline

dlj created this revision.May 10 2019, 8:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2019, 8:50 PM
thakis accepted this revision.May 13 2019, 10:06 AM

lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc; 2. Consider omitting unused llvm_build_Lanai variable)

Thanks!

This revision is now accepted and ready to land.May 13 2019, 10:06 AM
dlj updated this revision to Diff 199361.May 13 2019, 8:48 PM

lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

Done. FTR:

llvm/lib/Target/Lanai/LanaiInstrInfo.h:#include "LanaiGenInstrInfo.inc"
llvm/lib/Target/Lanai/LanaiRegisterInfo.h:#include "LanaiGenRegisterInfo.inc"
llvm/lib/Target/Lanai/LanaiSubtarget.h:#include "LanaiGenSubtargetInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenRegisterInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenInstrInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenSubtargetInfo.inc"

This matches the behavior for most other Target libraries in D61859.

  1. Consider omitting unused llvm_build_Lanai variable)

Done.