Page MenuHomePhabricator

gn build: add Hexagon target
ClosedPublic

Authored by dlj on May 10 2019, 9:22 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

dlj created this revision.May 10 2019, 9:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2019, 9:22 PM
thakis accepted this revision.May 13 2019, 10:07 AM

Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc; 2. Consider omitting unused llvm_build_Hexago variable)

Thanks!

This revision is now accepted and ready to land.May 13 2019, 10:07 AM
dlj updated this revision to Diff 199366.May 13 2019, 9:10 PM

Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;

Done, to satisfy:

llvm/lib/Target/Hexagon/HexagonInstrInfo.h:#include "HexagonGenInstrInfo.inc"
llvm/lib/Target/Hexagon/HexagonISelDAGToDAG.h: #include "HexagonGenDAGISel.inc"
llvm/lib/Target/Hexagon/HexagonRegisterInfo.h:#include "HexagonGenRegisterInfo.inc"
llvm/lib/Target/Hexagon/HexagonSubtarget.h:#include "HexagonGenSubtargetInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenRegisterInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenInstrInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenSubtargetInfo.inc"

  1. Consider omitting unused llvm_build_Hexago variable)

Done.

Closed by commit rL360647: gn build: add Hexagon target (authored by dlj, committed by ). · Explain WhyMay 13 2019, 9:11 PM
This revision was automatically updated to reflect the committed changes.