Page MenuHomePhabricator

[crt] Use -std=c11 for crtbegin.o/crtend.o
ClosedPublic

Authored by phosek on May 10 2019, 11:56 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.May 10 2019, 11:56 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 10 2019, 11:56 AM
Herald added subscribers: llvm-commits, Restricted Project, mgorny. · View Herald Transcript
thakis accepted this revision.May 10 2019, 12:05 PM

lgtm, but shouldn't we set this globally for all projects?

This revision is now accepted and ready to land.May 10 2019, 12:05 PM
phosek updated this revision to Diff 199050.May 10 2019, 12:16 PM
phosek retitled this revision from [crt] Use -std=c99 for crtbegin.o/crtend.o to [crt] Use -std=c11 for crtbegin.o/crtend.o.
phosek edited the summary of this revision. (Show Details)

lgtm, but shouldn't we set this globally for all projects?

I've noticed that builtins use C11 (https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/builtins/CMakeLists.txt#L575) so I've done the same here. I'm fine unifying this but I'd prefer to do it in a followup.

This revision was automatically updated to reflect the committed changes.