Page MenuHomePhabricator

[NewPassManager] Add tuning option: SLPVectorization [NFC].
ClosedPublic

Authored by asbirlea on May 6 2019, 4:04 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.May 6 2019, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 4:04 PM
chandlerc accepted this revision.May 6 2019, 4:07 PM

LGTM

Eric was hoping for some API improvements here as we add more tuning options, but I don't think these need to be sequenced.

This revision is now accepted and ready to land.May 6 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.
jvesely added a subscriber: jvesely.EditedMay 9 2019, 11:46 PM

@asbirlea, are you sure this was enabled by default before? (cl::init(true))
I've traced regressions in r600 and amdgcn to this patch.
Both can be fixed by changing the default to false.
While those regressions look like backend bugs, the commit message says NFC.

@jvesely: Yes, you are right. D61955 should resolve this.