This is an archive of the discontinued LLVM Phabricator instance.

Differential D61590

[AArch64] Default to SEH exception handling on MinGW
ClosedPublic

Authored by mstorsjo on May 6 2019, 6:08 AM.

Details

Reviewers
rnk
efriedma
mgrang
ssijaric
Commits
rZORGbd4d63c6ba8e: [AArch64] Default to SEH exception handling on MinGW
rZORG62c8e9c53350: [AArch64] Default to SEH exception handling on MinGW
rGbd4d63c6ba8e: [AArch64] Default to SEH exception handling on MinGW
rG62c8e9c53350: [AArch64] Default to SEH exception handling on MinGW
rG899f3cd5817e: [AArch64] Default to SEH exception handling on MinGW
rL360080: [AArch64] Default to SEH exception handling on MinGW
Summary

The SEH implementation is pretty mature at this point.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.May 6 2019, 6:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 6:08 AM
Herald added subscribers: kristof.beyls, javed.absar. · View Herald Transcript
efriedma accepted this revision.May 6 2019, 10:21 AM

LGTM

This revision is now accepted and ready to land.May 6 2019, 10:21 AM
rnk accepted this revision.May 6 2019, 10:37 AM

lgtm, makes sense.

mgrang accepted this revision.May 6 2019, 12:03 PM
Closed by commit rL360080: [AArch64] Default to SEH exception handling on MinGW (authored by mstorsjo). · Explain WhyMay 6 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
AArch64/
MCTargetDesc/
4 lines
test/
CodeGen/
AArch64/
2 lines
4 lines

Diff 198338

llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp

Show First 20 Lines • Show All 124 Lines • ▼ Show 20 LinesAArch64MCAsmInfoGNUCOFF::AArch64MCAsmInfoGNUCOFF() {
Data32bitsDirective = "\t.word\t"; Data32bitsDirective = "\t.word\t";
Data64bitsDirective = "\t.xword\t"; Data64bitsDirective = "\t.xword\t";
AlignmentIsInBytes = false; AlignmentIsInBytes = false;
SupportsDebugInformation = true; SupportsDebugInformation = true;
CodePointerSize = 8; CodePointerSize = 8;
CommentString = "//"; CommentString = "//";
ExceptionsType = ExceptionHandling::DwarfCFI; ExceptionsType = ExceptionHandling::WinEH;
// The default is dwarf, but WinEH can be enabled optionally, which requires
// WinEHEncodingType to be set.
WinEHEncodingType = WinEH::EncodingType::Itanium; WinEHEncodingType = WinEH::EncodingType::Itanium;
} }

llvm/trunk/test/CodeGen/AArch64/dwarf-cfi.ll

; RUN: llc -mtriple aarch64-windows-gnu -filetype=asm -o - %s | FileCheck %s ; RUN: llc -mtriple aarch64-windows-gnu -exception-model=dwarf -filetype=asm -o - %s | FileCheck %s
define void @_Z1gv() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) { define void @_Z1gv() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
entry: entry:
invoke void @_Z1fv() invoke void @_Z1fv()
to label %try.cont unwind label %lpad to label %try.cont unwind label %lpad
lpad: lpad:
%0 = landingpad { i8*, i32 } %0 = landingpad { i8*, i32 }
Show All 27 Lines

llvm/trunk/test/CodeGen/AArch64/wineh-mingw.ll

; RUN: llc < %s -exception-model=wineh -mtriple=aarch64-pc-mingw32 | FileCheck %s -check-prefix=WINEH ; RUN: llc < %s -mtriple=aarch64-pc-mingw32 | FileCheck %s -check-prefix=WINEH
; RUN: llc < %s -exception-model=wineh -mtriple=aarch64-pc-mingw32 -filetype=obj | llvm-readobj -S | FileCheck %s -check-prefix=WINEH-SECTIONS ; RUN: llc < %s -mtriple=aarch64-pc-mingw32 -filetype=obj | llvm-readobj -S | FileCheck %s -check-prefix=WINEH-SECTIONS
; Check emission of eh handler and handler data ; Check emission of eh handler and handler data
declare i32 @_d_eh_personality(i32, i32, i64, i8*, i8*) declare i32 @_d_eh_personality(i32, i32, i64, i8*, i8*)
declare void @_d_eh_resume_unwind(i8*) declare void @_d_eh_resume_unwind(i8*)
declare i32 @bar() declare i32 @bar()
define i32 @foo4() #0 personality i32 (i32, i32, i64, i8*, i8*)* @_d_eh_personality { define i32 @foo4() #0 personality i32 (i32, i32, i64, i8*, i8*)* @_d_eh_personality {
Show All 38 Lines