Page MenuHomePhabricator

[Driver] Change the way we deal with local lldbinit files.
ClosedPublic

Authored by JDevlieghere on May 5 2019, 6:48 PM.

Details

Summary

Currently we have special handling for local lldbinit files in the driver. At the same time, we have an SB API named SourceInitFileInCurrentWorkingDirectory that does the same thing. This patch removes the special handling from the driver and uses the API instead. In addition to the obvious advantages of having one canonical way of doing things and removing code duplication, this change also means that the code path is the same for global and local lldb init files. This is important for another patch I have in the pipeline.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.May 5 2019, 6:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2019, 6:48 PM

Looks good to me. The way we were working around this thing in the driver always looked like a hack to me.

clayborg accepted this revision.May 6 2019, 9:26 AM
This revision is now accepted and ready to land.May 6 2019, 9:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 1:43 PM