This is an archive of the discontinued LLVM Phabricator instance.

Fix use of 'is' operator for comparison
AbandonedPublic

Authored by tambre on May 4 2019, 1:59 AM.

Download Raw Diff

Details

Reviewers

zturner
labath

Summary

The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython.
CPython 3.8 has added a SyntaxWarning for this.

Diff Detail

Repository: rLLDB LLDB

Event Timeline

tambre created this revision.May 4 2019, 1:59 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2019, 1:59 AM

Herald added a subscriber: lldb-commits. · View Herald Transcript

labath accepted this revision.May 5 2019, 9:07 AM

This revision is now accepted and ready to land.May 5 2019, 9:07 AM

tambre abandoned this revision.Apr 3 2020, 2:24 AM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptApr 3 2020, 2:24 AM

Why did you abandon this?

In D61548#1960310, @JDevlieghere wrote:

Why did you abandon this?

It's been lingering for a long time, so I wanted to get it off my dashboard.
The patch also requires updating as the file has moved.

I rewrote this test in acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 so this isn't necessary anymore. Thanks for the patch though!

Revision Contents

Path

Size

lldb/

packages/

Python/

lldbsuite/

test/

lang/

cpp/

scope/

TestCppScope.py

4 lines

Diff 198131

lldb/packages/Python/lldbsuite/test/lang/cpp/scope/TestCppScope.py

Context not available.
	"target variable returns wrong variable " + name)	"target variable returns wrong variable " + name)

	for name in global_variables_assert:	for name in global_variables_assert:
	if name is "C::a" and not test_c:	if name == "C::a" and not test_c:
	continue	continue
	if name is not "C::a" and test_c:	if name != "C::a" and test_c:
	continue	continue

	value = frame.EvaluateExpression(name)	value = frame.EvaluateExpression(name)
Context not available.