This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Don't generate unused table entries.
ClosedPublic

Authored by sbc100 on May 3 2019, 2:29 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.May 3 2019, 2:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 2:29 PM
sbc100 updated this revision to Diff 198094.May 3 2019, 2:37 PM
  • remove comment
sbc100 added a reviewer: ruiu.May 3 2019, 2:38 PM
ruiu accepted this revision.May 7 2019, 12:25 AM

LGTM

lld/wasm/Writer.cpp
1159 ↗(On Diff #198094)

nit: auto* -> auto *

This revision is now accepted and ready to land.May 7 2019, 12:25 AM
sbc100 updated this revision to Diff 198485.May 7 2019, 8:43 AM
  • feedback
This revision was automatically updated to reflect the committed changes.

I bisected the failure on emscripten's wasm0.test_dylink_rtti (and two others, also failing on the waterfall) which hits

exception thrown: RuntimeError: function signature mismatch,RuntimeError: function signature mismatch

To bisect, I ran

./emcc --clear-cache && ./tests/runner.py wasm0.test_dylink_rtti

on each iteration to make sure there isn't some local influence.

OK, I'll revert this for now while I investigate.