Page MenuHomePhabricator

[gn] Update the clangd test lit site configuration
ClosedPublic

Authored by phosek on May 2 2019, 11:52 AM.

Details

Reviewers
thakis
Summary

This reflects changes made in r359763.

Diff Detail

Event Timeline

phosek created this revision.May 2 2019, 11:52 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 2 2019, 11:52 AM

Thanks! This is incomplete:

  • Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there
  • Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there

Else out/gn/bin/llvm-lit clang-tools-extra/clangd/test/path/to/test won't work.

Compare to all the other test targets (e.g. clang-tools-extra) for an example.

phosek updated this revision to Diff 197837.May 2 2019, 12:02 PM

Thanks! This is incomplete:

  • Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there
  • Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there

    Else out/gn/bin/llvm-lit clang-tools-extra/clangd/test/path/to/test won't work.

    Compare to all the other test targets (e.g. clang-tools-extra) for an example.

Done

thakis accepted this revision.May 2 2019, 12:34 PM
This revision is now accepted and ready to land.May 2 2019, 12:34 PM
thakis closed this revision.May 2 2019, 8:08 PM

This landed in r359825.