This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove redundant patterns for sub
ClosedPublic

Authored by arsenm on May 2 2019, 3:53 AM.

Download Raw Diff

Details

Reviewers

Summary

There were 2 patterns for sub, one selecting to sub and one to
subrev. Only one of these will succeed, so remove the reversed one.

Diff Detail

Event Timeline

arsenm created this revision.May 2 2019, 3:53 AM

Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptMay 2 2019, 3:53 AM

LGTM

This revision is now accepted and ready to land.May 2 2019, 11:50 AM

r359894

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

VOP2Instructions.td

4 lines

Diff 197739

lib/Target/AMDGPU/VOP2Instructions.td

Show First 20 Lines • Show All 522 Lines • ▼ Show 20 Lines	let AddedComplexity = 1 in {
def : DivergentBinOp<srl, V_LSHRREV_B32_e64>;		def : DivergentBinOp<srl, V_LSHRREV_B32_e64>;
def : DivergentBinOp<sra, V_ASHRREV_I32_e64>;		def : DivergentBinOp<sra, V_ASHRREV_I32_e64>;
def : DivergentBinOp<shl, V_LSHLREV_B32_e64>;		def : DivergentBinOp<shl, V_LSHLREV_B32_e64>;
}		}

let SubtargetPredicate = HasAddNoCarryInsts in {		let SubtargetPredicate = HasAddNoCarryInsts in {
def : DivergentBinOp<add, V_ADD_U32_e32>;		def : DivergentBinOp<add, V_ADD_U32_e32>;
def : DivergentBinOp<sub, V_SUB_U32_e32>;		def : DivergentBinOp<sub, V_SUB_U32_e32>;
def : DivergentBinOp<sub, V_SUBREV_U32_e32>;
}		}

let SubtargetPredicate = isGFX6GFX7GFX8GFX9, Predicates = [isGFX6GFX7GFX8GFX9] in {		let SubtargetPredicate = isGFX6GFX7GFX8GFX9, Predicates = [isGFX6GFX7GFX8GFX9] in {
def : DivergentBinOp<add, V_ADD_I32_e32>;		def : DivergentBinOp<add, V_ADD_I32_e32>;

def : DivergentBinOp<sub, V_SUB_I32_e32>;		def : DivergentBinOp<sub, V_SUB_I32_e32>;

def : DivergentBinOp<sub, V_SUBREV_I32_e32>;

def : DivergentBinOp<srl, V_LSHRREV_B32_e32>;		def : DivergentBinOp<srl, V_LSHRREV_B32_e32>;
def : DivergentBinOp<sra, V_ASHRREV_I32_e32>;		def : DivergentBinOp<sra, V_ASHRREV_I32_e32>;
def : DivergentBinOp<shl, V_LSHLREV_B32_e32>;		def : DivergentBinOp<shl, V_LSHLREV_B32_e32>;
}		}
def : DivergentBinOp<adde, V_ADDC_U32_e32>;		def : DivergentBinOp<adde, V_ADDC_U32_e32>;
def : DivergentBinOp<sube, V_SUBB_U32_e32>;		def : DivergentBinOp<sube, V_SUBB_U32_e32>;

class divergent_i64_BinOp <SDPatternOperator Op, Instruction Inst> :		class divergent_i64_BinOp <SDPatternOperator Op, Instruction Inst> :
▲ Show 20 Lines • Show All 817 Lines • Show Last 20 Lines