Page MenuHomePhabricator

[benchmark] Fix win32 link on case-sensitive fs
ClosedPublic

Authored by jschueller on May 1 2019, 3:49 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jschueller created this revision.May 1 2019, 3:49 AM

Please can you submit this upstream first?

Please can you submit this upstream first?

https://github.com/google/benchmark/blob/master/src/CMakeLists.txt

Yes, please create a pull request on google-benchmark's github first

lebedev.ri retitled this revision from Fix win32 link on case-sensitive fs to [benchmark] Fix win32 link on case-sensitive fs.May 1 2019, 12:46 PM
  1. Please note there is one more copy of benchmark, in testsuite repo. Not sure if you care about that one, but it may be better to fix this in all of them at once.
  2. There is a llvm/utils/benchmark/README.LLVM and libcxx/utils/google-benchmark/README.LLVM (and in testsuite, if you change that one too) that needs to be updated to document this cherry-pick from upstream.

@jschueller never replied there, so it got stuck.
I could take that over, but i'd need an *explicit* acknowledgement that it is ok to steal that from @jschueller from @jschueller.

ok, you can "steal" my patch : )

lebedev.ri requested changes to this revision.Mon, Jul 22, 6:15 AM

Submitted
https://github.com/google/benchmark/pull/840
yesterday, it just landed.
Please update README.llvm in these bundled copies to reflect this cherry-pick.
(BTW, there is one more copy, in test-suite, not sure if that matters)

This revision now requires changes to proceed.Mon, Jul 22, 6:15 AM

@lebedev.ri I think you can commandeer this

This revision was not accepted when it landed; it landed in state Needs Revision.Tue, Jul 30, 1:47 PM
Closed by commit rL367356: [benchmark] Fix win32 link on case-sensitive fs (authored by lebedevri, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.